| Summary: | Make getVTablePointer() an inline function to be compliant with WebKit style guidelines. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||||||
| Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206804 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Mark Lam
2020-01-26 21:19:01 PST
Created attachment 388823 [details]
proposed patch.
Comment on attachment 388823 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=388823&action=review > Source/WTF/wtf/PointerPreparations.h:36 > #if __has_builtin(__builtin_get_vtable_pointer) Why is this after the CPU(ARM64E) check. Wouldn't we want to use the builtin if it exists, regardless of what the CPU is? Comment on attachment 388823 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=388823&action=review >> Source/WTF/wtf/PointerPreparations.h:36 >> #if __has_builtin(__builtin_get_vtable_pointer) > > Why is this after the CPU(ARM64E) check. Wouldn't we want to use the builtin if it exists, regardless of what the CPU is? Good point. I'll rearrange the #ifs. Thanks. Created attachment 388824 [details]
patch for landing.
Comment on attachment 388824 [details] patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=388824&action=review > Source/WTF/wtf/PointerPreparations.h:34 > #if __has_builtin(__builtin_get_vtable_pointer) Oops, this isn’t good for non-clang compilers, like on Windows. Comment on attachment 388824 [details] patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=388824&action=review >> Source/WTF/wtf/PointerPreparations.h:34 >> #if __has_builtin(__builtin_get_vtable_pointer) > > Oops, this isn’t good for non-clang compilers, like on Windows. What Anders did for things like this in Compiler.h is: #if defined(__has_builtin) && __has_builtin(__builtin_get_vtable_pointer) This apparently works on all the compilers. Created attachment 388826 [details]
patch for landing.
Comment on attachment 388826 [details] patch for landing. Clearing flags on attachment: 388826 Committed r255139: <https://trac.webkit.org/changeset/255139> All reviewed patches have been landed. Closing bug. |