Bug 206810

Summary: [LFC][IFC] Display::Run has physical geometry only.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2020-01-26 14:49:29 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-26 14:49:46 PST 
<rdar://problem/58905455>
Comment 2 zalan 2020-01-26 14:57:39 PST 
Created attachment 388816 [details]
Patch
Comment 3 zalan 2020-01-26 17:50:22 PST 
Created attachment 388820 [details]
Patch
Comment 4 Antti Koivisto 2020-01-27 02:09:55 PST 
Comment on attachment 388820 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388820&action=review

> Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h:-54
> -    FloatRect logicalRect() const

You can also remove this from SimplePath and ComplexPath.
Comment 5 zalan 2020-01-27 06:35:22 PST 
(In reply to Antti Koivisto from comment #4)
> Comment on attachment 388820 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388820&action=review
> 
> > Source/WebCore/rendering/line/LineLayoutTraversalDisplayRunPath.h:-54
> > -    FloatRect logicalRect() const
> 
> You can also remove this from SimplePath and ComplexPath.

good point!
Comment 6 zalan 2020-01-27 06:39:10 PST 
Created attachment 388853 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-27 07:25:38 PST 
Comment on attachment 388853 [details]
Patch

Clearing flags on attachment: 388853

Committed r255143: <https://trac.webkit.org/changeset/255143>
Comment 8 WebKit Commit Bot 2020-01-27 07:25:40 PST 
All reviewed patches have been landed.  Closing bug.