Bug 206800

Summary: Regression (r255103): media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls.html
Product: WebKit Reporter: Aakash Jain <aakash_jain>
Component: Tools / TestsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, eric.carlson, jer.noble, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206772
Attachments:
Description Flags
Patch for landing none

Comment 1 Aakash Jain 2020-01-25 09:39:47 PST 
Diff:

--- /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls-expected.txt
+++ /Volumes/Data/worker/iOS-13-Simulator-WK2-Tests-EWS/build/layout-test-results/media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls-actual.txt
@@ -1,12 +1,5 @@
-Testing the PlacardSupport behavior when playing media through AirPlay in fullscreen.
+#PID UNRESPONSIVE - WebKitTestRunnerApp (pid 52717)
+FAIL: Timed out waiting for notifyDone to be called
 
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS mediaController.controls.placard is mediaController.controls.airplayPlacard
-PASS mediaController.controls.children.includes(mediaController.controls.airplayPlacard) is true
-
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
+#EOF
+#EOF
Comment 2 Jer Noble 2020-01-25 10:30:33 PST 
Created attachment 388780 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2020-01-25 11:14:27 PST 
Comment on attachment 388780 [details]
Patch for landing

Clearing flags on attachment: 388780

Committed r255122: <https://trac.webkit.org/changeset/255122>
Comment 4 WebKit Commit Bot 2020-01-25 11:14:28 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-01-25 11:15:13 PST 
<rdar://problem/58895887>
Comment 6 Alexey Proskuryakov 2020-01-25 13:08:51 PST 
Comment on attachment 388780 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=388780&action=review

> LayoutTests/platform/ios/TestExpectations:3005
>  media/modern-media-controls/placard-support/placard-support-airplay-fullscreen.html [ Skip ]
> +media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls.html [ Skip ]

It would be useful to reference bug 166062 here, e.g.

webkit.org/b/166062 media/modern-media-controls/placard-support/placard-support-airplay-fullscreen-no-controls.html [ Skip ]