| Summary: | WebCore: Remove iOS 11 macros from RenderThemeIOS.mm | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | WebCore Misc. | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, dino, esprehn+autocc, ews-watchlist, glenn, jonlee, kondapallykalyan, pdr, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206096 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-01-24 17:50:50 PST
Created attachment 388751 [details]
Patch
Comment on attachment 388751 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388751&action=review > Source/WTF/wtf/PlatformHave.h:571 > +#define HAVE_FONT_STYLE_0 1 > +#define HAVE_FONT_STYLE_4 1 I think "font style 0" is simply too brief to be unambiguous. I think it should be more like SYSTEM_FONT_STYLE_TITLE_0. > Source/WebCore/rendering/RenderThemeIOS.mm:1269 > +#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) Forgot to use HAVE here. > Source/WebCore/rendering/RenderThemeIOS.mm:1287 > +#if !PLATFORM(WATCHOS) && !PLATFORM(APPLETV) And here. Created attachment 388857 [details]
Patch
Comment on attachment 388857 [details] Patch Clearing flags on attachment: 388857 Committed r255219: <https://trac.webkit.org/changeset/255219> All reviewed patches have been landed. Closing bug. |