Bug 206744

Summary: [LFC][Painting] Add Display::Run cleanup to TextPainter::clearGlyphDisplayLists
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, mmaxfield, pdr, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description zalan 2020-01-24 07:21:16 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-24 07:21:35 PST 
<rdar://problem/58867112>
Comment 2 zalan 2020-01-24 07:28:27 PST 
Created attachment 388686 [details]
Patch
Comment 3 zalan 2020-01-24 07:32:43 PST 
ifdef all the things
Comment 4 zalan 2020-01-24 07:34:37 PST 
Created attachment 388687 [details]
Patch
Comment 5 Antti Koivisto 2020-01-24 07:35:53 PST 
Comment on attachment 388687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388687&action=review

> Source/WebCore/rendering/TextPainter.cpp:219
> +#if ENABLE(LAYOUT_FORMATTING_CONTEXT)
> +    GlyphDisplayListCache<Display::Run>::singleton().clear();
> +#endif

Could have runtime check too to avoid unnecessary construction of the singleton.
Comment 6 zalan 2020-01-24 07:39:43 PST 
Created attachment 388688 [details]
Patch
Comment 7 WebKit Commit Bot 2020-01-24 08:42:32 PST 
Comment on attachment 388688 [details]
Patch

Clearing flags on attachment: 388688

Committed r255074: <https://trac.webkit.org/changeset/255074>
Comment 8 WebKit Commit Bot 2020-01-24 08:42:34 PST 
All reviewed patches have been landed.  Closing bug.