| Summary: | Web Inspector: consolidate UIProcess/WebProcess files into Inspector folders | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Devin Rousso <hi> | ||||||||||||||||||
| Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||||
| Severity: | Normal | CC: | achristensen, annulen, Basuke.Suzuki, bburg, cdumez, cgarcia, chris.reid, commit-queue, dbates, don.olmstead, ews-watchlist, gyuyoung.kim, hi, Hironori.Fujii, inspector-bugzilla-changes, japhet, joepeck, mcatanzaro, mkwst, pnormand, ross.kirsling, ryuan.choi, sergio, timothy, webkit-bug-importer, zan | ||||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||||
| Version: | WebKit Local Build | ||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||
| OS: | All | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Devin Rousso
2020-01-23 17:23:05 PST
Created attachment 388635 [details]
Patch
Created attachment 388636 [details]
Patch
Created attachment 388637 [details]
Patch
Created attachment 388640 [details]
Patch
Created attachment 388644 [details]
Patch
Created attachment 388647 [details]
Patch
Created attachment 388658 [details]
Patch
Any reason this is a cq? Devin? Socket side seems fine. (In reply to Don Olmstead from comment #8) > Any reason this is a cq? Devin? I was waiting for EWS to be all green. > Socket side seems fine. Thanks for taking a look! =D Comment on attachment 388658 [details] Patch Rejecting attachment 388658 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 388658, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 5000 characters of output: tcher.cpp patching file Source/WebKit/WebProcess/Inspector/WebInspectorFrontendAPIDispatcher.h patching file Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.cpp patching file Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.h patching file Source/WebKit/WebProcess/Inspector/WebInspectorInterruptDispatcher.messages.in patching file Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp patching file Source/WebKit/WebProcess/Inspector/WebInspectorUI.h patching file Source/WebKit/WebProcess/Inspector/WebInspectorUI.messages.in patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.cpp patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTarget.h patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.cpp patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetController.h patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.cpp patching file Source/WebKit/WebProcess/Inspector/WebPageInspectorTargetFrontendChannel.h patching file Source/WebKit/WebProcess/Inspector/gtk/WebInspectorUIGtk.cpp patching file Source/WebKit/WebProcess/Inspector/mac/WebInspectorUIMac.mm patching file Source/WebKit/WebProcess/Inspector/win/WebInspectorUIWin.cpp patching file Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp rm 'Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.cpp' patching file Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.h rm 'Source/WebKit/WebProcess/WebCoreSupport/WebInspectorClient.h' patching file Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp rm 'Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.cpp' patching file Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h rm 'Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.h' patching file Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.messages.in rm 'Source/WebKit/WebProcess/WebPage/RemoteWebInspectorUI.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebInspector.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspector.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspector.h rm 'Source/WebKit/WebProcess/WebPage/WebInspector.h' patching file Source/WebKit/WebProcess/WebPage/WebInspector.messages.in rm 'Source/WebKit/WebProcess/WebPage/WebInspector.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h rm 'Source/WebKit/WebProcess/WebPage/WebInspectorFrontendAPIDispatcher.h' patching file Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.h rm 'Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.h' patching file Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in rm 'Source/WebKit/WebProcess/WebPage/WebInspectorInterruptDispatcher.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp rm 'Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp' patching file Source/WebKit/WebProcess/WebPage/WebInspectorUI.h rm 'Source/WebKit/WebProcess/WebPage/WebInspectorUI.h' patching file Source/WebKit/WebProcess/WebPage/WebInspectorUI.messages.in rm 'Source/WebKit/WebProcess/WebPage/WebInspectorUI.messages.in' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.cpp rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.cpp' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.h rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTarget.h' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.cpp rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.cpp' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.h rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetController.h' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.cpp rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.cpp' patching file Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.h rm 'Source/WebKit/WebProcess/WebPage/WebPageInspectorTargetFrontendChannel.h' patching file Source/WebKit/WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp rm 'Source/WebKit/WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp' patching file Source/WebKit/WebProcess/WebPage/mac/WebInspectorUIMac.mm rm 'Source/WebKit/WebProcess/WebPage/mac/WebInspectorUIMac.mm' patching file Source/WebKit/WebProcess/WebPage/win/WebInspectorUIWin.cpp rm 'Source/WebKit/WebProcess/WebPage/win/WebInspectorUIWin.cpp' Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13311960 Created attachment 388831 [details]
Patch
Comment on attachment 388831 [details] Patch Clearing flags on attachment: 388831 Committed r255214: <https://trac.webkit.org/changeset/255214> All reviewed patches have been landed. Closing bug. Unreviewed, speculative gtk build fix: <https://trac.webkit.org/r255231> |