| Summary: | macCatalyst: I-Beam is too conservative, doesn't show up in editable areas with no text | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, mifenton, simon.fraser, webkit-bug-importer, wenson_hsieh, zalan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2020-01-23 16:38:00 PST
Created attachment 388615 [details]
Patch
Comment on attachment 388615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388615&action=review > Source/WebCore/editing/VisiblePosition.cpp:675 > + Node* node = m_deepPosition.anchorNode(); auto* > Source/WebCore/editing/VisiblePosition.cpp:679 > + InlineBox* inlineBox; nullptr it please > Source/WebCore/editing/VisiblePosition.cpp:680 > + int caretOffset; this should have an initial value too > Source/WebCore/editing/VisiblePosition.cpp:687 > + FloatRect localRect(root.x(), root.selectionTop(), root.width(), root.selectionHeight()); isn't "auto localRect = FloatRect { }" the preferred way by now? Comment on attachment 388615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388615&action=review > Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:2759 > + auto renderer = hitTestResult.innerNode()->renderer(); auto* Created attachment 388633 [details]
Patch
|