Bug 206706

Summary: Get rid of didFinishParsing and make parseInner return its results
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 197106    
Attachments:
Description Flags
patch
mark.lam: review+
patch for landing none

Description Saam Barati 2020-01-23 15:34:42 PST 
Cleans up some code and makes parseInner less stateful. This should make it easier to eagerly parse IIFE
Comment 1 Saam Barati 2020-01-23 17:26:43 PST 
Created attachment 388626 [details]
patch
Comment 2 Mark Lam 2020-01-23 17:31:08 PST 
Comment on attachment 388626 [details]
patch

r=me
Comment 3 Keith Miller 2020-01-23 17:31:19 PST 
Comment on attachment 388626 [details]
patch

r=me.
Comment 4 Yusuke Suzuki 2020-01-23 17:31:24 PST 
Comment on attachment 388626 [details]
patch

r=me too, nice. didFinishParsing looks ugly.
Comment 5 Saam Barati 2020-01-23 18:09:48 PST 
Created attachment 388632 [details]
patch for landing
Comment 6 WebKit Commit Bot 2020-01-23 18:54:42 PST 
Comment on attachment 388632 [details]
patch for landing

Clearing flags on attachment: 388632

Committed r255047: <https://trac.webkit.org/changeset/255047>
Comment 7 WebKit Commit Bot 2020-01-23 18:54:44 PST 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2020-01-23 18:55:14 PST 
<rdar://problem/58857211>
Comment 9 Yusuke Suzuki 2020-01-23 21:42:01 PST 
Committed r255053: <https://trac.webkit.org/changeset/255053>
Comment 10 Saam Barati 2020-01-24 11:12:16 PST 
(In reply to Yusuke Suzuki from comment #9)
> Committed r255053: <https://trac.webkit.org/changeset/255053>

oops. Thanks for fixing