Bug 206701

Summary: [Mac wk2 Release] fast/dom/frame-src-javascript-url-async.html flaky failing
Product: WebKit Reporter: Jason Lawrence <Lawrence.j>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, koivisto, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Jason Lawrence
Reported 2020-01-23 14:11:49 PST
fast/dom/frame-src-javascript-url-async.html Description: This test is flaky failing on Mac wk2 release. History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fframe-src-javascript-url-async.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/dom/frame-src-javascript-url-async-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/dom/frame-src-javascript-url-async-actual.txt @@ -9,11 +9,12 @@ PASS frame1.contentWindow is initialFrame1Window PASS frame1.contentDocument is initialFrame1Document PASS frame2.contentWindow is initialFrame2Window -PASS frame2.contentDocument is not initialFrame2Document +FAIL frame2.contentDocument should not be [object HTMLDocument]. PASS frame2.contentWindow is initialFrame2Window -PASS frame2.contentDocument is not initialFrame2Document +FAIL frame2.contentDocument should not be [object HTMLDocument]. PASS frame2.contentDocument.documentElement.textContent is "1" PASS successfullyParsed is true +Some tests failed. TEST COMPLETE
Attachments
patch (1.73 KB, patch)
2020-01-27 00:43 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-23 14:12:15 PST
<rdar://problem/58847864>
Alexey Proskuryakov
Comment 2 2020-01-26 12:37:12 PST
This test has been flakily failing on slower internal bots for as long as history goes. But there is a very sharp increase in frequency in January. Unclear what caused it.
Antti Koivisto
Comment 3 2020-01-27 00:43:49 PST
Created attachment 388837 [details] patch
Antoine Quint
Comment 4 2020-01-27 02:20:31 PST
Comment on attachment 388837 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=388837&action=review > LayoutTests/ChangeLog:15 > + ⦠Might want to get rid of this.
WebKit Commit Bot
Comment 5 2020-01-27 03:20:21 PST
The commit-queue encountered the following flaky tests while processing attachment 388837 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2020-01-27 03:20:48 PST
Comment on attachment 388837 [details] patch Clearing flags on attachment: 388837 Committed r255140: <https://trac.webkit.org/changeset/255140>
WebKit Commit Bot
Comment 7 2020-01-27 03:20:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.