| Summary: | Centralize AuxiliaryProcessMainBase implementations | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Don Olmstead <don.olmstead> | ||||||||||||
| Component: | WebKit2 | Assignee: | Don Olmstead <don.olmstead> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | annulen, aperez, cgarcia, clopez, commit-queue, ews-watchlist, gyuyoung.kim, Hironori.Fujii, ryuan.choi, sergio, webkit-bug-importer, zan | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Don Olmstead
2020-01-23 13:58:44 PST
Created attachment 388600 [details]
WIP Patch
Created attachment 388604 [details]
WIP Patch
Fix linker errors maybe
Created attachment 388605 [details]
WIP Patch
Will it link?
Created attachment 388610 [details]
WIP Patch
Add in PluginProcess for consistency
Created attachment 388616 [details]
Patch
Since a lot of stuff is renamed or moved the diff might be a bit weird. Other than that ready to review by Team Igalia!
Comment on attachment 388616 [details] Patch Clearing flags on attachment: 388616 Committed r255067: <https://trac.webkit.org/changeset/255067> All reviewed patches have been landed. Closing bug. Comment on attachment 388616 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388616&action=review > Source/WebKit/NetworkProcess/curl/NetworkProcessMainCurl.cppSource/WebKit/NetworkProcess/win/NetworkProcessMainWin.cpp:40 > + globalNetworkProcess->destroySession(PAL::SessionID::defaultSessionID()); Filed: Bug 206817 – [WinCairo][curl] ASSERTION FAILED: sessionID != PAL::SessionID::defaultSessionID() in NetworkProcess since r255067 |