Bug 206675

Summary: REGRESSION: [Mac wk2] fast/animation/request-animation-frame.html is flaky failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: AnimationsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, sabouhallawa, simon.fraser, thorton, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Jacob Uphoff
Reported 2020-01-23 10:22:06 PST
fast/animation/request-animation-frame.html is flaky failing on Mojave wk2 starting around commit 254128 I did not try to reproduce History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fanimation%2Frequest-animation-frame.html Diff: --- /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk2/build/layout-test-results/fast/animation/request-animation-frame-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS callbackInvoked is true +FAIL callbackInvoked should be true. Was false. PASS successfullyParsed is true TEST COMPLETE
Attachments
Patch (3.11 KB, patch)
2020-01-27 08:49 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.11 KB, patch)
2020-01-27 09:41 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Truitt Savell
Comment 1 2020-01-23 10:41:52 PST
This looks like it was fixed for a time around 254405 then broke again around 254790
Radar WebKit Bug Importer
Comment 2 2020-01-23 10:41:53 PST
<rdar://problem/58839955>
Chris Dumez
Comment 3 2020-01-27 08:49:59 PST
Created attachment 388864 [details] Patch
Said Abou-Hallawa
Comment 4 2020-01-27 08:59:42 PST
Comment on attachment 388864 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388864&action=review > LayoutTests/fast/animation/request-animation-frame.html:8 > <span id="e"></span> > <span id="f"></span> Do we still need these two elements?
Chris Dumez
Comment 5 2020-01-27 09:41:19 PST
(In reply to Said Abou-Hallawa from comment #4) > Comment on attachment 388864 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388864&action=review > > > LayoutTests/fast/animation/request-animation-frame.html:8 > > <span id="e"></span> > > <span id="f"></span> > > Do we still need these two elements? No, will drop' em
Chris Dumez
Comment 6 2020-01-27 09:41:34 PST
Created attachment 388868 [details] Patch
WebKit Commit Bot
Comment 7 2020-01-27 10:39:05 PST
Comment on attachment 388868 [details] Patch Clearing flags on attachment: 388868 Committed r255153: <https://trac.webkit.org/changeset/255153>
WebKit Commit Bot
Comment 8 2020-01-27 10:39:07 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.