Bug 206669

Summary:

[iOS] REGRESSION(r254699) : fast/forms/interactive-validation-remove-node-in-handler.html is timing out

Product:

WebKit

Reporter:

Jason Lawrence <Lawrence.j>

Component:

New Bugs

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, rniwa, simon.fraser, webkit-bot-watchers-bugzilla, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes interactive-validation-prevented.html	none

Description Jason Lawrence 2020-01-23 09:46:02 PST

fast/forms/interactive-validation-remove-node-in-handler.html

Description:
This test is timing out. It looks like this regressed around 254700. I have not tried to reproduce this.

History:
https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Finteractive-validation-remove-node-in-handler.html

Diff:
--- /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/forms/interactive-validation-remove-node-in-handler-expected.txt
+++ /Volumes/Data/slave/ios-simulator-13-release-tests-wk2/build/layout-test-results/fast/forms/interactive-validation-remove-node-in-handler-actual.txt
@@ -1,8 +1 @@
-Should not crash or have an assertion failure if a node was removed during an "invalid" event dispatching for the node.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS The form was submitted.
-TEST COMPLETE
- 
+TestController::platformResetPreferencesToConsistentValues - Failed to remove presented view controller

Comment 1 Radar WebKit Bug Importer 2020-01-23 09:46:34 PST

<rdar://problem/58837865>

Comment 2 Ryosuke Niwa 2020-01-24 18:41:37 PST

r254700 only affects WK1 so it can’t be it. It’s most certainly https://trac.webkit.org/r254699.

Comment 3 Ryosuke Niwa 2020-01-24 18:42:29 PST

Reproduction:
run-webkit-tests --debug --ios-simulator --no-retry fast/forms/interactive-validation-remove-node-in-handler.html

Comment 4 Ryosuke Niwa 2020-01-24 18:42:51 PST

(In reply to Ryosuke Niwa from comment #3)
> Reproduction:
> run-webkit-tests --debug --ios-simulator --no-retry
> fast/forms/interactive-validation-remove-node-in-handler.html

Oops, this doesn't work.

This does:
run-webkit-tests --debug --ios-simulator --no-retry fast/forms/interactive-validation-prevented.html fast/forms/interactive-validation-remove-node-in-handler.html

Comment 5 Ryosuke Niwa 2020-01-24 19:24:15 PST

Created attachment 388756 [details]
Fixes interactive-validation-prevented.html

Comment 6 Ryosuke Niwa 2020-01-24 19:27:36 PST

I can definitely dismiss the invalidation bubble manually. I'm not certain why WTR doesn't dismiss these bubbles automatically but there are other tests that manually dismiss invalidation bubbles (fast/forms/interactive-validation-select-crash.html) so do that for now.

Comment 7 Ryosuke Niwa 2020-01-24 19:48:34 PST

(In reply to Ryosuke Niwa from comment #6)
> I can definitely dismiss the invalidation bubble manually. I'm not certain
> why WTR doesn't dismiss these bubbles automatically but there are other
> tests that manually dismiss invalidation bubbles
> (fast/forms/interactive-validation-select-crash.html) so do that for now.

Apparently Simon deiced that it's better for each test to be cleaning itself up instead of automatically doing it in the test runner so this is expected.

Comment 8 Ryosuke Niwa 2020-01-24 20:24:11 PST

Comment on attachment 388756 [details]
Fixes interactive-validation-prevented.html

Clearing flags on attachment: 388756

Committed r255115: <https://trac.webkit.org/changeset/255115>

Comment 9 Ryosuke Niwa 2020-01-24 20:24:13 PST

All reviewed patches have been landed.  Closing bug.