Bug 206668

Summary: REGRESSION: [MacOS wk1] fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html is flaky failing
Product: WebKit Reporter: Jacob Uphoff <jacob_uphoff>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ryanhaddad, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Update Test Expectations
none
Update Test Expectations
none
Update Test Expectations
none
Update Test Expectations none

Description Jacob Uphoff 2020-01-23 09:28:47 PST 
fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html is flaky failing and was first seen on commit 252050 but not sure if that is the origin.

I did not try to reproduce the failure, it is happening on macOS wk1.

History:

https://results.webkit.org/?suite=layout-tests&test=fast%2Floader%2Fredirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html

Diff:

--- /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-expected.txt
+++ /Volumes/Data/slave/catalina-debug-tests-wk1/build/layout-test-results/fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate-actual.txt
@@ -1,4 +1,3 @@
-Policy delegate: attempt to load http://a=a&b=b/ with navigation type 'other'
 Tests that we do not redirect to an invalid URL initiated by <meta http-equiv="refresh">. This test PASSED if you see an entry in the dumped frame load callbacks of the form: "willPerformClientRedirectToURL: http://A=a&B=b" followed by "didCancelClientRedirectForFrame".
 
 Note, this test must be run in DumpRenderTree.
Comment 1 Radar WebKit Bug Importer 2020-01-23 09:29:13 PST 
<rdar://problem/58837324>
Comment 2 Truitt Savell 2020-01-23 10:18:46 PST 
This test does reproduce easily by running it in iterations. It reproduces on much older builds than the suggested regression point so I still cannot tell when this may have started.
Comment 3 Ryan Haddad 2020-01-23 12:45:23 PST 
Looking at this example:
https://build.webkit.org/results/Apple-Catalina-Debug-WK1-Tests/r254577%20(1809)/results.html

The line that is missing in the diff for fast/loader/redirect-to-invalid-url-using-meta-refresh-calls-policy-delegate.html is unexpectedly present in the diff for fast/loader/redirect-to-invalid-url-using-meta-refresh-disallowed-async-delegates.html

In every failure I looked at, both tests fail together as described above.
Comment 4 Alexey Proskuryakov 2020-01-24 23:02:50 PST 

*** This bug has been marked as a duplicate of bug 180760 ***
Comment 5 Jacob Uphoff 2020-01-28 08:30:40 PST 
Reopening to attach new patch.
Comment 6 Jacob Uphoff 2020-01-28 08:30:41 PST 
Created attachment 388999 [details]
Update Test Expectations
Comment 7 Jacob Uphoff 2020-01-28 08:34:43 PST 
Created attachment 389001 [details]
Update Test Expectations
Comment 8 Jacob Uphoff 2020-01-28 08:46:07 PST 
Created attachment 389005 [details]
Update Test Expectations
Comment 9 Jacob Uphoff 2020-01-28 08:51:11 PST 
Created attachment 389008 [details]
Update Test Expectations
Comment 10 Truitt Savell 2020-01-28 08:53:43 PST 
Comment on attachment 389008 [details]
Update Test Expectations

Clearing flags on attachment: 389008

Committed r255242: <https://trac.webkit.org/changeset/255242>
Comment 11 Ryan Haddad 2020-01-28 09:23:00 PST 

*** This bug has been marked as a duplicate of bug 180760 ***