Bug 206654

Summary: :matches() doesn't combine correctly with pseudo elements
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, ap, bfulgham, commit-queue, emilio, esprehn+autocc, esprehn, ews-watchlist, glenn, gyuyoung.kim, macpherson, menard, simon.fraser, webkit-bug-importer, xidorn-webkit, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206651
Bug Depends on:    
Bug Blocks: 206848    
Attachments:
Description Flags
patch
none
patch
none
patch
none
patch none

Description Antti Koivisto 2020-01-23 05:24:42 PST 
Selectors like 

::matches(foo, .parent .child)::first-letter

never match.
Comment 1 Antti Koivisto 2020-01-23 05:25:41 PST 
:matches(foo, .parent .child)::first-letter
Comment 2 Antti Koivisto 2020-01-23 05:49:23 PST 
Created attachment 388537 [details]
patch
Comment 3 Antti Koivisto 2020-01-23 07:39:24 PST 
Created attachment 388542 [details]
patch
Comment 4 Antti Koivisto 2020-01-23 07:43:41 PST 
Created attachment 388543 [details]
patch
Comment 5 Antti Koivisto 2020-01-23 09:01:07 PST 
Created attachment 388551 [details]
patch
Comment 6 Simon Fraser (smfr) 2020-01-23 12:46:46 PST 
How does this relate to bug 145357, bug 181078, and bug 198204 ?
Comment 7 Antti Koivisto 2020-01-24 00:02:16 PST 
*** Bug 145357 has been marked as a duplicate of this bug. ***
Comment 8 Antti Koivisto 2020-01-24 00:03:23 PST 
*** Bug 181078 has been marked as a duplicate of this bug. ***
Comment 9 Antti Koivisto 2020-01-24 00:03:52 PST 
*** Bug 198204 has been marked as a duplicate of this bug. ***
Comment 10 WebKit Commit Bot 2020-01-24 00:37:12 PST 
Comment on attachment 388551 [details]
patch

Clearing flags on attachment: 388551

Committed r255059: <https://trac.webkit.org/changeset/255059>
Comment 11 WebKit Commit Bot 2020-01-24 00:37:14 PST 
All reviewed patches have been landed.  Closing bug.
Comment 12 Radar WebKit Bug Importer 2020-01-24 00:38:16 PST 
<rdar://problem/58861903>