Bug 206623

Summary: Add an option for logging total phase times
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, guijemont, keith_miller, mark.lam, msaboff, rmorisset, ticaiolima, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch for landing none

Description Saam Barati 2020-01-22 15:53:01 PST
...
Comment 1 Saam Barati 2020-01-22 17:08:11 PST
Created attachment 388490 [details]
patch
Comment 2 Robin Morisset 2020-01-22 17:13:22 PST
Comment on attachment 388490 [details]
patch

r=me
Comment 3 Keith Miller 2020-01-22 17:15:17 PST
Comment on attachment 388490 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388490&action=review

r=me too with comment.

> Source/JavaScriptCore/runtime/OptionsList.h:167
> +    v(Bool, reportTotalPhaseTimes, false, Normal, nullptr) \

Plox add a string here that explains the difference between this only prints at the end.
Comment 4 Saam Barati 2020-01-22 17:18:34 PST
Created attachment 388492 [details]
patch for landing
Comment 5 WebKit Commit Bot 2020-01-22 18:27:31 PST
Comment on attachment 388492 [details]
patch for landing

Clearing flags on attachment: 388492

Committed r254957: <https://trac.webkit.org/changeset/254957>
Comment 6 WebKit Commit Bot 2020-01-22 18:27:32 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-22 18:28:13 PST
<rdar://problem/58820257>