| Summary: | [JSC] Bits from Operand should fit in bits reserved in AbstractHeap's Payload | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yusuke Suzuki <ysuzuki> | ||||
| Component: | New Bugs | Assignee: | Yusuke Suzuki <ysuzuki> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206650 | ||||||
| Attachments: |
|
||||||
|
Description
Yusuke Suzuki
2020-01-22 15:24:28 PST
Created attachment 388475 [details]
Patch
Comment on attachment 388475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388475&action=review r=me with suggestion. > Source/JavaScriptCore/bytecode/Operands.h:41 > +enum class OperandKind : uint32_t { Argument, Local, Tmp }; // Keep bit-width in sync with Operand::operandKindBits' definition. Nit You can add a `LastOperandKind = Tmp` then compute kindBits from that via getMSBSet. Comment on attachment 388475 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388475&action=review >> Source/JavaScriptCore/bytecode/Operands.h:41 >> +enum class OperandKind : uint32_t { Argument, Local, Tmp }; // Keep bit-width in sync with Operand::operandKindBits' definition. > > Nit You can add a `LastOperandKind = Tmp` then compute kindBits from that via getMSBSet. Sounds nice. Fixed. Committed r254968: <https://trac.webkit.org/changeset/254968> Follow-up fix. https://trac.webkit.org/changeset/254975/webkit |