| Summary: | Fix iOS 13.2 iphoneos build | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jonathan Bedard <jbedard> | ||||||
| Component: | Tools / Tests | Assignee: | Jonathan Bedard <jbedard> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, dbates, ews-watchlist, jlewis3, krollin, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206620 | ||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Bedard
2020-01-22 15:23:52 PST
Created attachment 388477 [details]
Patch
Comment on attachment 388477 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388477&action=review > Tools/Scripts/webkitdirs.pm:884 > + push @options, "-IDEProvisioningProfileSupportRelaxed=YES"; Maybe limit this to embedded platforms? It will be a little confusing when looking at macOS logs for future unrelated failures. (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 388477 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388477&action=review > > > Tools/Scripts/webkitdirs.pm:884 > > + push @options, "-IDEProvisioningProfileSupportRelaxed=YES"; > > Maybe limit this to embedded platforms? It will be a little confusing when > looking at macOS logs for future unrelated failures. We could do this and fix our immediate problem. But https://bugs.webkit.org/show_bug.cgi?id=206620 would just end up undoing that. We don't pass platform arguments to webkitdirs when doing make, and I had trouble thinking up a situation where relaxing provisioning rules was wrong. If we think we want to continue passing platform specific arguments to xcodebuild, we need to pass the platform we're using to webkitdirs when running make. Created attachment 388491 [details]
Patch
Talked a bit with Alexey about this offline. My reason for applying this argument globally was some issues with https://bugs.webkit.org/show_bug.cgi?id=206620, but that is actually indicative of a larger bug in how make invokes webkitdirs. For now, we'll do this for embedded builds only, and address the make issues in https://bugs.webkit.org/show_bug.cgi?id=206620. Comment on attachment 388491 [details] Patch Rejecting attachment 388491 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 388491, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=388491&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=206618&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Processing patch 388491 from bug 206618. Fetching: https://bugs.webkit.org/attachment.cgi?id=388491 Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitdirs.pm Hunk #1 FAILED at 888. 1 out of 1 hunk FAILED -- saving rejects to file Tools/Scripts/webkitdirs.pm.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: https://webkit-queues.webkit.org/results/13310391 Committed r254978: <https://trac.webkit.org/changeset/254978> |