Bug 206612

Summary: uniqueLogIdentifier() should generate a unique identifiers
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, cdumez, cmarcelo, commit-queue, dbates, ews-watchlist, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 200403    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Description Eric Carlson 2020-01-22 13:59:33 PST 
uniqueLogIdentifier() should generate a unique identifiers
Comment 1 Eric Carlson 2020-01-22 14:03:14 PST 
Created attachment 388467 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-01-22 15:43:51 PST 
<rdar://problem/58814158>
Comment 3 Brent Fulgham 2020-01-22 17:27:55 PST 
Comment on attachment 388467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388467&action=review

r=me

> Source/WTF/wtf/LoggerHelper.h:69
> +        uint64_t lowWord = cryptographicallyRandomNumber();

Whoops!
Comment 4 WebKit Commit Bot 2020-01-22 18:25:29 PST 
Comment on attachment 388467 [details]
Patch

Clearing flags on attachment: 388467

Committed r254956: <https://trac.webkit.org/changeset/254956>
Comment 5 WebKit Commit Bot 2020-01-22 18:25:31 PST 
All reviewed patches have been landed.  Closing bug.