Bug 206608

Summary: REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit Misc.Assignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brady Eidson
Reported 2020-01-22 12:24:49 PST
REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated <rdar://problem/58544942>
Attachments
Patch (4.41 KB, patch)
2020-01-22 12:39 PST, Brady Eidson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2020-01-22 12:39:49 PST
Created attachment 388459 [details] Patch
Alex Christensen
Comment 2 2020-01-22 13:00:37 PST
Comment on attachment 388459 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388459&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:235 > + TCPServer server([](int socket) { You could've used HTTPServer since this only adds headers fields and body, but this is fine too.
WebKit Commit Bot
Comment 3 2020-01-22 15:48:35 PST
Comment on attachment 388459 [details] Patch Clearing flags on attachment: 388459 Committed r254950: <https://trac.webkit.org/changeset/254950>
WebKit Commit Bot
Comment 4 2020-01-22 15:48:36 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.