Bug 206581

Summary:

[LFC] Do not create a FormattingContext to compute intrinsic width unless there's some content.

Product:

WebKit

Reporter:

alan baradlay <zalan>

Component:

Layout and Rendering

Assignee:

alan baradlay <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

alan baradlay

Reported 2020-01-22 08:07:58 PST

Currently we construct FCs to compute the intrinsic width even when the root has no content (and we end up returning an empty IntrinsicWidthConstraints.

Attachments
Patch (5.34 KB, patch) 2020-01-22 09:21 PST, alan baradlay	no flags	Details Formatted Diff Diff
Patch (5.34 KB, patch) 2020-01-22 10:39 PST, alan baradlay	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2020-01-22 09:10:55 PST

<rdar://problem/58798593>

alan baradlay

Comment 2 2020-01-22 09:21:31 PST

Created attachment 388429 [details] Patch

WebKit Commit Bot

Comment 3 2020-01-22 10:31:10 PST Comment hidden (obsolete)

Comment on attachment 388429 [details] Patch Rejecting attachment 388429 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 388429, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=388429&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=206581&ctype=xml&excludefield=attachmentdata Processing 1 patch from 1 bug. Updating working directory Processing patch 388429 from bug 206581. Fetching: https://bugs.webkit.org/attachment.cgi?id=388429 Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'buildbot': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $ret in chomp at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git.pm line 596. Use of uninitialized value in concatenation (.) or string at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git/SVN/Prompt.pm line 20. Password for '': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $ret in chomp at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git.pm line 596. Use of uninitialized value in concatenation (.) or string at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git/SVN/Prompt.pm line 20. Password for '': ERROR from SVN: Authentication failed: No more credentials or we tried too many times. Authentication failed W: b9e8f7311d9f133660c42adeea55cc56d6a58278 and refs/remotes/origin/master differ, using rebase: :040000 040000 e90047a22cf291a9120f8da2ecd50ac9c85b29ea faf3b4aab57dc7c62e625eec0253a7739a4ecdee M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Committing to http://svn.webkit.org/repository/webkit/trunk ... Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Password for 'buildbot': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $ret in chomp at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git.pm line 596. Use of uninitialized value in concatenation (.) or string at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git/SVN/Prompt.pm line 20. Password for '': Authentication realm: <http://svn.webkit.org:80> Mac OS Forge Username: Use of uninitialized value $ret in chomp at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git.pm line 596. Use of uninitialized value in concatenation (.) or string at /Applications/Xcode.app/Contents/Developer/usr/share/git-core/perl/Git/SVN/Prompt.pm line 20. Password for '': ERROR from SVN: Authentication failed: No more credentials or we tried too many times. Authentication failed W: b9e8f7311d9f133660c42adeea55cc56d6a58278 and refs/remotes/origin/master differ, using rebase: :040000 040000 e90047a22cf291a9120f8da2ecd50ac9c85b29ea faf3b4aab57dc7c62e625eec0253a7739a4ecdee M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource From https://git.webkit.org/git/WebKit 3cf18bc55f0..29ac667b9f1 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 254927 = 3cf18bc55f006c19b0ab50af977b8c94166859b6 r254928 = 29ac667b9f17a47576cb1d74c1458f039261efe1 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: https://webkit-queues.webkit.org/results/13309821

alan baradlay

Comment 4 2020-01-22 10:39:36 PST

Created attachment 388437 [details] Patch

WebKit Commit Bot

Comment 5 2020-01-22 11:46:04 PST

Comment on attachment 388437 [details] Patch Clearing flags on attachment: 388437 Committed r254933: <https://trac.webkit.org/changeset/254933>

WebKit Commit Bot

Comment 6 2020-01-22 11:46:06 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.