| Summary: | Remove ImageBuffer::sizeForDestinationSize() | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Component: | Canvas | Assignee: | Said Abou-Hallawa <sabouhallawa> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | alecflett, annulen, beidson, cdumez, cmarcelo, commit-queue, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, fred.wang, glenn, graouts, gyuyoung.kim, jer.noble, jsbell, kondapallykalyan, luiz, macpherson, menard, noam, pdr, philipj, ryuan.choi, schenney, sergio, simon.fraser, thorton, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Bug Depends on: | 206519 | ||||||||||||
| Bug Blocks: | 204955 | ||||||||||||
| Attachments: |
|
||||||||||||
Created attachment 388315 [details]
Patch
Created attachment 388342 [details]
Patch
Created attachment 388402 [details]
Patch
Created attachment 388457 [details]
Patch
The commit-queue encountered the following flaky tests while processing attachment 388457 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 388457 [details] Patch Clearing flags on attachment: 388457 Committed r254941: <https://trac.webkit.org/changeset/254941> All reviewed patches have been landed. Closing bug. |
This function is currently does nothing. For CG ports, it scales a rect by the ratio backingStoreSize / internalSize which is always 1. The constructor ImageBuffer::ImageBuffer() sets m_size and m_data.backingStoreSize to the same value always. m_size = IntSize(scaledWidth, scaledHeight); m_data.backingStoreSize = m_size; For other ports ImageBuffer::sizeForDestinationSize() returns the passed rectangle.