Bug 206540

Summary: [macOS] Add managed preference to allow synchronous XHR during page dismissal
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, dbates, ews-watchlist, ggaren, japhet, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206944
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2020-01-21 09:41:45 PST 
Add managed preference to allow synchronous XHR during page dismissal. This is temporarily needed by some enterprise products until they can update their code.
Comment 1 Chris Dumez 2020-01-21 09:43:11 PST 
<rdar://problem/58644447>
Comment 2 Chris Dumez 2020-01-21 09:46:18 PST 
Created attachment 388311 [details]
Patch
Comment 3 Alex Christensen 2020-01-21 12:41:47 PST 
Comment on attachment 388311 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388311&action=review

r=me

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:67
> +bool defaultDisallowSyncXHRDuringPageDismissalEnabled()

To avoid double negatives, could we rename this to defaultAllow...
Same with the preference name.

> Source/WebKit/Shared/WebPreferencesDefaultValues.cpp:75
> +    return true;

We should put a FIXME with a radar for iOS.
Comment 4 Chris Dumez 2020-01-21 12:52:34 PST 
Created attachment 388338 [details]
Patch
Comment 5 Chris Dumez 2020-01-21 14:02:44 PST 
Comment on attachment 388338 [details]
Patch

The changed proposed by Alex does not work because WebKitTestRunner turns ON all experimental features.
Comment 6 Chris Dumez 2020-01-21 14:04:19 PST 
Committed r254880: <https://trac.webkit.org/changeset/254880>