Bug 206518

Summary: Rename JSPromiseFields abstract heap to JSInternalFields.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, keith_miller, msaboff, saam, tuomas.webkit, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
none
proposed patch none

Description Mark Lam 2020-01-20 23:43:22 PST 
This is because it is used for all internal fields, not just the ones in JSPromise.
Comment 1 Radar WebKit Bug Importer 2020-01-20 23:43:45 PST 
<rdar://problem/58751778>
Comment 2 Mark Lam 2020-01-20 23:50:18 PST 
Created attachment 388281 [details]
proposed patch.
Comment 3 Yusuke Suzuki 2020-01-21 00:57:44 PST 
Comment on attachment 388281 [details]
proposed patch.

r=me
Comment 4 WebKit Commit Bot 2020-01-21 01:41:08 PST 
Comment on attachment 388281 [details]
proposed patch.

Clearing flags on attachment: 388281

Committed r254846: <https://trac.webkit.org/changeset/254846>
Comment 5 WebKit Commit Bot 2020-01-21 01:41:10 PST 
All reviewed patches have been landed.  Closing bug.
Comment 6 Tuomas Karkkainen 2020-01-21 04:29:54 PST 
Created attachment 388289 [details]
proposed patch

- fixes Tools/Scripts/set-webkit-configuration --reset
- addresses some comments
Comment 7 Tuomas Karkkainen 2020-01-21 04:31:04 PST 
(In reply to Tuomas Karkkainen from comment #6)
> Created attachment 388289 [details]
> proposed patch
> 
> - fixes Tools/Scripts/set-webkit-configuration --reset
> - addresses some comments

oops wrong issue.