Bug 206507

Summary:

[LFC][IFC] InlineFormattingContext::lineLayout should take a InlineItem range

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2020-01-20 11:49:19 PST

instead of going from 0 to InlineItemList.size()

Comment 1 Radar WebKit Bug Importer 2020-01-20 11:49:55 PST

<rdar://problem/58742468>

Comment 2 zalan 2020-01-20 12:18:46 PST

Created attachment 388249 [details]
Patch

Comment 3 Antti Koivisto 2020-01-20 12:20:39 PST

Comment on attachment 388249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388249&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54
> +        bool isEmpty() const { return start >= end; }

Why would start > end?

Comment 4 zalan 2020-01-20 12:37:35 PST

(In reply to Antti Koivisto from comment #3)
> Comment on attachment 388249 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388249&action=review
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.h:54
> > +        bool isEmpty() const { return start >= end; }
> 
> Why would start > end?
indeed why would.

Comment 5 zalan 2020-01-20 12:55:59 PST

Created attachment 388251 [details]
Patch

Comment 6 WebKit Commit Bot 2020-01-20 15:32:56 PST

Comment on attachment 388251 [details]
Patch

Clearing flags on attachment: 388251

Committed r254837: <https://trac.webkit.org/changeset/254837>

Comment 7 WebKit Commit Bot 2020-01-20 15:32:57 PST

All reviewed patches have been landed.  Closing bug.