Bug 206492

Summary: Import 2 sets of grid-align-tests from WPT
Product: WebKit Reporter: rmonteriso
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ews-watchlist, jfernandez, rego, rmonteriso, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description rmonteriso 2020-01-20 02:25:09 PST 
This patch moves some grid-align tests to the imported/w3c/web-platform-tests after they have been adapted and merged in the WPT repository:

https://github.com/web-platform-tests/wpt/pull/19862/

* css/css-grid/alignment/grid-align-stretching-replaced-items.html
* css/support/blue-100.png

https://github.com/web-platform-tests/wpt/pull/19823/

* css/css-grid/alignment/grid-align-content-vertical-lr.html
* css/css-grid/alignment/grid-align-content-vertical-rl.html

Their corresponding outdated tests in fast/css-grid-layout have been removed.
Comment 1 rmonteriso 2020-01-22 02:45:14 PST 
Created attachment 388409 [details]
Patch
Comment 2 rmonteriso 2020-01-23 03:32:40 PST 
Created attachment 388532 [details]
Patch
Comment 3 rmonteriso 2020-01-23 10:08:39 PST 
Created attachment 388559 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2020-01-24 00:44:53 PST 
Comment on attachment 388559 [details]
Patch

r=me assuming that the tests under imported/w3c/ are synced with the ones in WPT.
Comment 5 rmonteriso 2020-01-24 01:55:25 PST 
Yes, these tests are updated to the latest version of WPT tests and incorporate the cosmetic change introduced by the following Chromium CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2010769
Comment 6 Manuel Rego Casasnovas 2020-01-24 02:32:19 PST 
Comment on attachment 388559 [details]
Patch

(In reply to rmonteriso from comment #5)
> Yes, these tests are updated to the latest version of WPT tests and
> incorporate the cosmetic change introduced by the following Chromium CL:
> https://chromium-review.googlesource.com/c/chromium/src/+/2010769

Great, the Chromium CL has landed and merged in WPT so we can land this now.
Comment 7 WebKit Commit Bot 2020-01-24 03:18:10 PST 
Comment on attachment 388559 [details]
Patch

Clearing flags on attachment: 388559

Committed r255064: <https://trac.webkit.org/changeset/255064>
Comment 8 WebKit Commit Bot 2020-01-24 03:18:11 PST 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2020-01-24 03:19:14 PST 
<rdar://problem/58863943>