| Summary: | [Media in GPU process] Pipe more MediaPlayerPrivate and client methods | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||||||||
| Component: | Media | Assignee: | Jon Lee <jonlee> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, peng.liu6, philipj, sergio, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Jon Lee
2020-01-17 23:58:31 PST
Created attachment 388136 [details]
Patch
Comment on attachment 388136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388136&action=review > Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp:476 > + m_webProcessConnection->send(Messages::RemoteMediaPlayerManager::CurrentPlaybackTargetIsWirelessChanged(m_id), 0); HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged immediately calls m_player->isCurrentPlaybackTargetWireless(), so we should push that state here and cache it in the MediaPlayerPrivateRemote. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:684 > + if (m_player) m_player is never NULL. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:942 > + if (m_player) Ditto. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:948 > + if (m_player) Ditto. > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:954 > + if (m_player) Ditto. Created attachment 388162 [details]
Patch
Comment on attachment 388162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388162&action=review Thanks! > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815 > + if (m_player) This test is unnecessary. Comment on attachment 388162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388162&action=review >> Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815 >> + if (m_player) > > This test is unnecessary. Whoops, will remove. Created attachment 388474 [details]
Patch
Comment on attachment 388474 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388474&action=review > Source/WebKit/WebProcess/GPU/media/MediaPlayerPrivateRemote.cpp:815 > + if (m_player) :-/ Created attachment 388481 [details]
Patch
Comment on attachment 388481 [details] Patch Clearing flags on attachment: 388481 Committed r254964: <https://trac.webkit.org/changeset/254964> All reviewed patches have been landed. Closing bug. |