Bug 206461

Summary:

JSModuleLoader's printableModuleKey() should never throw.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ews-watchlist, keith_miller, msaboff, saam, ticaiolima, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	msaboff: review+

Description Mark Lam 2020-01-17 16:49:00 PST

Hence, it should be using a CatchScope instead of a ThrowScope.

<rdar://problem/58696678>

Comment 1 Mark Lam 2020-01-17 16:55:14 PST

Created attachment 388117 [details]
proposed patch.

Comment 2 Michael Saboff 2020-01-17 16:58:56 PST

Comment on attachment 388117 [details]
proposed patch.

r=me

Comment 3 Mark Lam 2020-01-17 17:03:05 PST

Thanks for the review.  Landed in r254783: <http://trac.webkit.org/r254783>.

Comment 4 Caio Lima 2020-01-20 02:09:35 PST

*** Bug 206414 has been marked as a duplicate of this bug. ***