| Summary: | Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | beidson, cdumez, webkit-bug-importer, youennf | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Alex Christensen
2020-01-17 15:57:50 PST
Created attachment 388105 [details]
Patch
Some related API tests seem to fail. Created attachment 391820 [details]
Patch
Comment on attachment 391820 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391820&action=review > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:346 > - return _websiteDataStore->sourceApplicationBundleIdentifier(); > + return nil; Why leave this here at all? > Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStore.mm:351 > - (void)_setSourceApplicationBundleIdentifier:(NSString *)identifier > { > - if (!_websiteDataStore->setSourceApplicationBundleIdentifier(identifier)) > - [NSException raise:NSGenericException format:@"_setSourceApplicationBundleIdentifier cannot be called after networking has begun"]; > } Ditto |