Bug 206451

Summary: Remove std::lock_guard
Product: WebKit Reporter: Basuke Suzuki <Basuke.Suzuki>
Component: bmallocAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cdumez, cgarcia, cmarcelo, commit-queue, darin, eric.carlson, ews-watchlist, fred.wang, ggaren, glenn, hi, hta, jamesr, jbedard, jer.noble, jiewen_tan, joepeck, keith_miller, luiz, mark.lam, mmaxfield, msaboff, philipj, saam, sergio, tommyw, tonikitoo, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206443
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Basuke Suzuki 2020-01-17 15:31:42 PST
We are on C++ 17. https://en.cppreference.com/w/cpp/thread/scoped_lock
Comment 1 Yusuke Suzuki 2020-01-17 15:47:32 PST
https://trac.webkit.org/wiki/WebKitGTK/GCCRequirement
Our requirement is GCC7. So, we can use it.
https://www.gnu.org/software/gcc/gcc-7/changes.html
Comment 2 Basuke Suzuki 2020-01-17 16:39:14 PST
It generates exactly same code. We can safely replace this. https://godbolt.org/z/p-KTwc
Comment 3 Yusuke Suzuki 2020-02-29 02:00:17 PST
Created attachment 392054 [details]
Patch
Comment 4 Yusuke Suzuki 2020-02-29 02:13:41 PST
Created attachment 392055 [details]
Patch
Comment 5 Yusuke Suzuki 2020-02-29 02:41:48 PST
Created attachment 392057 [details]
Patch
Comment 6 Anders Carlsson 2020-02-29 07:02:41 PST
Comment on attachment 392057 [details]
Patch

OK.
Comment 7 Yusuke Suzuki 2020-02-29 20:13:35 PST
Comment on attachment 392057 [details]
Patch

Thanks
Comment 8 WebKit Commit Bot 2020-02-29 21:01:37 PST
Comment on attachment 392057 [details]
Patch

Clearing flags on attachment: 392057

Committed r257688: <https://trac.webkit.org/changeset/257688>
Comment 9 WebKit Commit Bot 2020-02-29 21:01:40 PST
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2020-02-29 21:02:17 PST
<rdar://problem/59925404>