| Summary: | [JSC] Add missing header guards | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Component: | JavaScriptCore | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: |
https://bugs.webkit.org/show_bug.cgi?id=206480 https://bugs.webkit.org/show_bug.cgi?id=206481 |
||||||
| Attachments: |
|
||||||
Created attachment 388095 [details]
Patch v1
Lol, we should really have a style warning for this... Comment on attachment 388095 [details] Patch v1 Clearing flags on attachment: 388095 Committed r254787: <https://trac.webkit.org/changeset/254787> All reviewed patches have been landed. Closing bug. (In reply to Keith Miller from comment #2) > Lol, we should really have a style warning for this... We do have a check, but it wasn't very good because it assumed any header that didn't already have #ifndef/#define/#endif or #pragma once was an Objective-C header that didn't need a header guard. Improving this in Bug 206480. |
Add missing header guards to JavaScriptCore headers as found by lgtm.com: Source/JavaScriptCore/heap/IsoHeapCellType.h Source/JavaScriptCore/wasm/WasmFaultSignalHandler.h