| Summary: | [bmalloc] Define alias for std::unique_lock and std::lock_guard for better readability | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Component: | bmalloc | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | Basuke.Suzuki, commit-queue, ggaren, saam, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206451 | ||||||||
| Attachments: |
|
||||||||
|
Description
Basuke Suzuki
2020-01-17 14:07:52 PST
Created attachment 388089 [details]
PATCH
Comment on attachment 388089 [details] PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=388089&action=review Loks good overall. > Source/bmalloc/bmalloc/Mutex.h:41 > +using SimpleLock = std::lock_guard<Mutex>; Rename it to UniqueLockHolder and LockHolder. The name “Lock” means the lock itself instead of RAII styled locking class. And consider using scoped_lock instead of lock_guard. Maybe we can use it now? (C++17) Created attachment 388096 [details]
PATCH
A bug for scoped_lock was filed. https://bugs.webkit.org/show_bug.cgi?id=206451 Comment on attachment 388096 [details]
PATCH
r=me
Thanks! Comment on attachment 388096 [details] PATCH Clearing flags on attachment: 388096 Committed r254781: <https://trac.webkit.org/changeset/254781> All reviewed patches have been landed. Closing bug. |