| Summary: | Some iOS tests using UIHelper.dragFromPointToPoint() are flakey | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | megan_gardner, simon.fraser, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Simon Fraser (smfr)
2020-01-17 13:39:21 PST
Created attachment 388085 [details]
Patch
Comment on attachment 388085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review r=mews > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:434 > +static NSDictionary *dictionaryForFingerEventWithContentPoint(CGPoint point, NSString* phase, Seconds timeOffset) Nit - * on other side. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:459 > + NSDictionary* touchDownInfo = dictionaryForFingerEventWithContentPoint(startPoint, HIDEventPhaseBegan, 0_s); Nit - * on other side. > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:467 > + NSDictionary* liftUpInfo = dictionaryForFingerEventWithContentPoint(endPoint, HIDEventPhaseEnded, Seconds(durationSeconds)); Ditto. Comment on attachment 388085 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388085&action=review > Tools/ChangeLog:14 > + and dispatching via -[HIDEventGenerator HIDEventGenerator:]. This spawns a thread to Nit - I think you meant to write "sendEventStream:completionBlock:". |