| Summary: | [EWS] Print disk space usage for windows bots | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Aakash Jain <aakash_jain> | ||||||
| Component: | Tools / Tests | Assignee: | Aakash Jain <aakash_jain> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | aakash_jain, ap, commit-queue, jbedard, tsavell, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | Other | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Aakash Jain
2020-01-17 09:19:43 PST
Created attachment 388046 [details]
Patch
Created attachment 388048 [details]
Patch
Comment on attachment 388048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:1888 > + command_list_win = [['df', '-hl']] Shouldn't this go into command_list_generic? Do we have a 4th class of machines? Comment on attachment 388048 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388048&action=review >> Tools/BuildSlaveSupport/ews-build/steps.py:1888 >> + command_list_win = [['df', '-hl']] > > Shouldn't this go into command_list_generic? Do we have a 4th class of machines? Yeah, the 4th category is wincairo. We don't want to run this command on wincairo since I believe wincairo doesn't use cygwin and windows doesn't have df command. The commit-queue encountered the following flaky tests while processing attachment 388048 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. Comment on attachment 388048 [details] Patch Clearing flags on attachment: 388048 Committed r254777: <https://trac.webkit.org/changeset/254777> All reviewed patches have been landed. Closing bug. Deployed on the production server. Working fine, e.g.: https://ews-build.webkit.org/#/builders/10/builds/4263/steps/2/logs/stdio |