| Summary: | ASSERT in case a service worker cannot be terminated in a timely manner | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||
| Component: | Service Workers | Assignee: | youenn fablet <youennf> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, cdumez, cgarcia, commit-queue, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=206396 | ||||||
| Attachments: |
|
||||||
|
Description
youenn fablet
2020-01-17 07:29:41 PST
Created attachment 388038 [details]
Patch
Comment on attachment 388038 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388038&action=review > Source/WebCore/workers/service/context/SWContextManager.cpp:168 > + ASSERT_NOT_REACHED(); > _exit(EXIT_FAILURE); Builds passed on EWS, but I recall some ports failing to build because of unreachable code warnings in the past. Maybe they disabled the warning. (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 388038 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388038&action=review > > > Source/WebCore/workers/service/context/SWContextManager.cpp:168 > > + ASSERT_NOT_REACHED(); > > _exit(EXIT_FAILURE); > > Builds passed on EWS, but I recall some ports failing to build because of > unreachable code warnings in the past. Maybe they disabled the warning. I remember hitting that issue on EWS. Either it has changed or the call to exit changes things? Will land it as is and will check webkit console. Comment on attachment 388038 [details] Patch Clearing flags on attachment: 388038 Committed r254812: <https://trac.webkit.org/changeset/254812> All reviewed patches have been landed. Closing bug. We are not hitting this assertion on tests where ServiceWorker process terminates unexpectedly. |