Bug 206411

Summary: [LFC][IFC] Allocate InlineItems in a vector
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
zalan: review+, commit-queue: commit-queue-
patch none

Description Antti Koivisto 2020-01-17 05:11:21 PST
Even the largest InlineItem (InlineTextItem) is small (fits to 24 bytes), and they are allocated in large numbers (one per word and per whitespace typically). Reduce heap allocations by turning InlineItem into a fixed size type.
Comment 1 Antti Koivisto 2020-01-17 05:22:11 PST
Created attachment 388031 [details]
patch
Comment 2 zalan 2020-01-17 06:18:54 PST
Comment on attachment 388031 [details]
patch

v.nice
Comment 3 WebKit Commit Bot 2020-01-17 07:07:06 PST
Comment on attachment 388031 [details]
patch

Rejecting attachment 388031 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 388031, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=388031&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=206411&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Updating working directory
Processing patch 388031 from bug 206411.
Fetching: https://bugs.webkit.org/attachment.cgi?id=388031
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 10 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
patching file Source/WebCore/layout/inlineformatting/InlineFormattingState.h
patching file Source/WebCore/layout/inlineformatting/InlineItem.cpp
patching file Source/WebCore/layout/inlineformatting/InlineItem.h
patching file Source/WebCore/layout/inlineformatting/InlineSoftLineBreakItem.h
patching file Source/WebCore/layout/inlineformatting/InlineTextItem.cpp
patching file Source/WebCore/layout/inlineformatting/InlineTextItem.h
patching file Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
Hunk #1 FAILED at 129.
Hunk #2 FAILED at 154.
Hunk #3 succeeded at 175 (offset -5 lines).
Hunk #4 succeeded at 325 (offset -5 lines).
Hunk #5 succeeded at 349 (offset -5 lines).
Hunk #6 succeeded at 357 (offset -5 lines).
2 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp.rej
patching file Source/WebCore/layout/inlineformatting/LineLayoutContext.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 10 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/layout/inlineformatting/InlineFormattingContext.cpp
patching file Source/WebCore/layout/inlineformatting/InlineFormattingState.h
patching file Source/WebCore/layout/inlineformatting/InlineItem.cpp
patching file Source/WebCore/layout/inlineformatting/InlineItem.h
patching file Source/WebCore/layout/inlineformatting/InlineSoftLineBreakItem.h
patching file Source/WebCore/layout/inlineformatting/InlineTextItem.cpp
patching file Source/WebCore/layout/inlineformatting/InlineTextItem.h
patching file Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp
Hunk #1 FAILED at 129.
Hunk #2 FAILED at 154.
Hunk #3 succeeded at 175 (offset -5 lines).
Hunk #4 succeeded at 325 (offset -5 lines).
Hunk #5 succeeded at 349 (offset -5 lines).
Hunk #6 succeeded at 357 (offset -5 lines).
2 out of 6 hunks FAILED -- saving rejects to file Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp.rej
patching file Source/WebCore/layout/inlineformatting/LineLayoutContext.h

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Zalan Bujtas']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
From https://git.webkit.org/git/WebKit
   2e7de0fa79e..72ae6f21987  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 254742 = 2e7de0fa79e3c832fbfc51cf243d794196e23b96
r254743 = 72ae6f21987c707abd9105bcdbc1bceae546c16f
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: https://webkit-queues.webkit.org/results/13306157
Comment 4 Antti Koivisto 2020-01-17 07:33:00 PST
Created attachment 388037 [details]
patch
Comment 5 WebKit Commit Bot 2020-01-17 08:16:07 PST
Comment on attachment 388037 [details]
patch

Clearing flags on attachment: 388037

Committed r254749: <https://trac.webkit.org/changeset/254749>
Comment 6 WebKit Commit Bot 2020-01-17 08:16:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2020-01-17 08:17:14 PST
<rdar://problem/58682783>