| Summary: | Video sound sometimes keeps playing in page cache | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||
| Component: | Media | Assignee: | youenn fablet <youennf> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gyuyoung.kim, jer.noble, philipj, sergio, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
youenn fablet
2020-01-17 04:01:05 PST
Created attachment 388026 [details]
Patch
Comment on attachment 388026 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388026&action=review > LayoutTests/http/tests/navigation/resources/page-cache-video-helper.html:7 > + localStorage.setItem("pageMediaState", internals.pageMediaState()); This state is never read back from the page cache, should it be? (In reply to Eric Carlson from comment #3) > Comment on attachment 388026 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=388026&action=review > > > LayoutTests/http/tests/navigation/resources/page-cache-video-helper.html:7 > > + localStorage.setItem("pageMediaState", internals.pageMediaState()); > > This state is never read back from the page cache, should it be? No, I forgot to remove it. I initially planned to use that state but this was not testing what I wanted so ended up with currentTime. Will remove it before landing. Created attachment 388208 [details]
Patch
Comment on attachment 388208 [details] Patch Clearing flags on attachment: 388208 Committed r254814: <https://trac.webkit.org/changeset/254814> All reviewed patches have been landed. Closing bug. |