Bug 206398

Summary: Add WKScriptMessageHandler API that asynchronously responds with a promise
Product: WebKit Reporter: Brady Eidson <beidson>
Component: WebKit APIAssignee: Brady Eidson <beidson>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, aestes, benjamin, berto, calvaris, cdumez, cgarcia, cmarcelo, eric.carlson, esprehn+autocc, ews-watchlist, glenn, gustavo, gyuyoung.kim, jer.noble, kondapallykalyan, philipj, sergio, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 210700    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch (omg maybe this is the one)
none
PFR none

Description Brady Eidson 2020-01-16 22:05:29 PST 
Add WKScriptMessageHandler API that asynchronously responds with a promise
Comment 1 Radar WebKit Bug Importer 2020-01-16 22:05:46 PST 
<rdar://problem/58671599>
Comment 2 Brady Eidson 2020-04-18 14:40:09 PDT 
(This is actually at rdar://problem/57243492)
Comment 3 Brady Eidson 2020-04-18 16:24:20 PDT 
Blocked on https://bugs.webkit.org/show_bug.cgi?id=210700 as we'll be adding new actual *API* that uses WKContentWorld, and therefore the bug described over in will become very real for more people
Comment 4 Brady Eidson 2020-04-18 23:53:22 PDT 
Created attachment 396895 [details]
Patch
Comment 5 Brady Eidson 2020-04-19 01:17:23 PDT 
Created attachment 396898 [details]
Patch

While I whittle away at the GTK/etc build failures, Mac and iOS are good to go.

Let's review!
Comment 6 EWS Watchlist 2020-04-19 01:18:10 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 7 Brady Eidson 2020-04-19 09:27:40 PDT 
Created attachment 396914 [details]
Patch
Comment 8 Brady Eidson 2020-04-19 09:45:57 PDT 
Created attachment 396915 [details]
Patch
Comment 9 Brady Eidson 2020-04-19 11:05:31 PDT 
Created attachment 396918 [details]
Patch
Comment 10 Brady Eidson 2020-04-19 11:40:45 PDT 
Created attachment 396919 [details]
Patch
Comment 11 Brady Eidson 2020-04-19 12:01:44 PDT 
Created attachment 396921 [details]
Patch
Comment 12 Brady Eidson 2020-04-19 12:15:54 PDT 
Created attachment 396923 [details]
Patch (omg maybe this is the one)
Comment 13 Brady Eidson 2020-04-19 13:22:56 PDT 
(In reply to Brady Eidson from comment #12)
> Created attachment 396923 [details]
> Patch (omg maybe this is the one)

It was. Updating ChangeLogs
Comment 14 Brady Eidson 2020-04-19 13:28:15 PDT 
Created attachment 396925 [details]
PFR
Comment 15 EWS 2020-04-19 22:55:17 PDT 
Committed r260350: <https://trac.webkit.org/changeset/260350>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 396925 [details].