Bug 206385

Summary: [iOS] Focusing editable element with WebPage::selectPositionAtPoint() does not bring up keyboard
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit2Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
For bots
none
Patch
none
To Land none

Description Daniel Bates 2020-01-16 16:30:06 PST 
When a hardware keyboard is not attached calling WebPage::selectPositionAtPoint() to focus an editable element does not bring up the keyboard.
Comment 1 Daniel Bates 2020-01-16 16:30:11 PST 
<rdar://problem/57414380>
Comment 2 Daniel Bates 2020-01-16 16:31:57 PST 
Created attachment 387981 [details]
For bots
Comment 3 Daniel Bates 2020-01-17 10:42:38 PST 
Created attachment 388057 [details]
Patch
Comment 4 Wenson Hsieh 2020-01-17 10:45:12 PST 
Comment on attachment 388057 [details]
Patch

This would preferably have a test.

I think you could write an API test for this that verifies -[_WKFocusedElementInfo userInitiated] is YES when using selectPositionAtPoint in a text field.
Comment 5 Wenson Hsieh 2020-01-17 10:50:52 PST 
Comment on attachment 388057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388057&action=review

> Source/WebKit/ChangeLog:14
> +        tagged selection change though the callers should be auditted to ensure they weren't accidentally

Nit - auditted
Comment 6 Daniel Bates 2020-01-17 10:54:44 PST 
Comment on attachment 388057 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388057&action=review

Thanks for the review!

>> Source/WebKit/ChangeLog:14
>> +        tagged selection change though the callers should be auditted to ensure they weren't accidentally
> 
> Nit - auditted

I'll audit it!
Comment 7 Daniel Bates 2020-01-17 10:57:02 PST 
Created attachment 388063 [details]
To Land
Comment 8 Daniel Bates 2020-01-17 11:00:02 PST 
Comment on attachment 388063 [details]
To Land

Clearing flags on attachment: 388063

Committed r254755: <https://trac.webkit.org/changeset/254755>
Comment 9 Daniel Bates 2020-01-17 11:00:04 PST 
All reviewed patches have been landed.  Closing bug.