| Summary: | Use the same AccessibilityObjectWrapper for associated AXObject and AXIsolatedObject. | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andres Gonzalez <andresg_22> | ||||||||||||
| Component: | New Bugs | Assignee: | Andres Gonzalez <andresg_22> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, annulen, apinheiro, cfleizach, commit-queue, dmazzoni, ews-watchlist, gyuyoung.kim, jcraig, jdiggs, ryuan.choi, samuel_white, sergio, webkit-bug-importer | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Andres Gonzalez
2020-01-16 16:22:20 PST
Created attachment 387992 [details]
Patch
Created attachment 387997 [details]
Uploading diff manually.
Created attachment 388555 [details]
Patch
Comment on attachment 388555 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388555&action=review > Source/WebCore/accessibility/AXObjectCache.h:176 > + void cacheAndInitializeWrapper(AccessibilityObject*, RenderObject* = nullptr, Node* = nullptr, Widget* = nullptr); don't know if this feasible, but would it be possible to templatize the "other" object (RenderObject/Node/Widget) so that there was only one parameter? > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm:354 > + if (!isMainThread()) should we add something like if (!clientSupportsIsolatedTree()) ASSERT_NOT_REACHED() Created attachment 388571 [details]
Patch
Created attachment 388620 [details]
Patch
Comment on attachment 388620 [details] Patch Clearing flags on attachment: 388620 Committed r255044: <https://trac.webkit.org/changeset/255044> All reviewed patches have been landed. Closing bug. |