Bug 206383

Summary: Fix assertion when test fast/events/ios/rotation/basic-rotation.html is followed by fast/events/ios/rotation/do-not-shrink-to-fit-content-after-rotation.html
Product: WebKit Reporter: Megan Gardner <megan_gardner>
Component: New BugsAssignee: Megan Gardner <megan_gardner>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, thorton, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing
none
Patch for landing none

Description Megan Gardner 2020-01-16 16:10:21 PST 
Early out of size transition if no size change
Comment 1 Megan Gardner 2020-01-16 16:13:22 PST 
Created attachment 387977 [details]
Patch
Comment 2 Megan Gardner 2020-01-16 16:14:03 PST 
<rdar://problem/58618513>
Comment 3 Tim Horton 2020-01-16 16:20:36 PST 
Comment on attachment 387977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387977&action=review

> Tools/ChangeLog:3
> +        Early out of size transition if no size change

The title needs to be a liiiitle more descriptive (I should at least know this is about WKTR)

> Tools/ChangeLog:9
> +        Rotation tests are asserting because _didEndRotation is being called multiple times.

What changed‽ Surely not this code.
Comment 4 Simon Fraser (smfr) 2020-01-16 16:25:40 PST 
Comment on attachment 387977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387977&action=review

>> Tools/ChangeLog:3
>> +        Early out of size transition if no size change
> 
> The title needs to be a liiiitle more descriptive (I should at least know this is about WKTR)

Yeah it should be "fix assertion when test foo runs after test bar (or at least mention the specific steps to reproduce in the bugzilla).
Comment 5 Megan Gardner 2020-01-17 10:15:45 PST 
Created attachment 388054 [details]
Patch
Comment 6 Tim Horton 2020-01-17 10:19:01 PST 
Comment on attachment 388054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388054&action=review

> Tools/ChangeLog:11
> +        size that the view already is. Thereform, iof no size is changing, early out,

iof
Comment 7 Wenson Hsieh 2020-01-17 10:19:46 PST 
(In reply to Tim Horton from comment #6)
> Comment on attachment 388054 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=388054&action=review
> 
> > Tools/ChangeLog:11
> > +        size that the view already is. Thereform, iof no size is changing, early out,
> 
> iof

(Nit - Thereform too)
Comment 8 Simon Fraser (smfr) 2020-01-17 11:05:18 PST 
Comment on attachment 388054 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=388054&action=review

> Tools/WebKitTestRunner/ios/PlatformWebViewIOS.mm:133
> +    

Whitespace!
Comment 9 Megan Gardner 2020-01-17 13:10:11 PST 
Created attachment 388079 [details]
Patch for landing
Comment 10 Megan Gardner 2020-01-17 13:13:28 PST 
Created attachment 388080 [details]
Patch for landing
Comment 11 Megan Gardner 2020-01-17 13:14:30 PST 
Created attachment 388081 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2020-01-17 13:57:35 PST 
Comment on attachment 388081 [details]
Patch for landing

Clearing flags on attachment: 388081

Committed r254765: <https://trac.webkit.org/changeset/254765>
Comment 13 WebKit Commit Bot 2020-01-17 13:57:36 PST 
All reviewed patches have been landed.  Closing bug.