Bug 206372

Summary: [LFC][IFC] Optimize LineLayoutContext::tryAddingInlineItems for the most common inline content
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, koivisto, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description zalan 2020-01-16 14:15:31 PST 
ssia
Comment 1 Radar WebKit Bug Importer 2020-01-16 14:15:47 PST 
<rdar://problem/58657525>
Comment 2 zalan 2020-01-16 14:17:56 PST 
Created attachment 387958 [details]
Patch
Comment 3 Simon Fraser (smfr) 2020-01-16 14:21:58 PST 
Comment on attachment 387958 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387958&action=review

> Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:209
> +inline void LineCandidateContent::reset()

Does the inlining actually make a difference?
Comment 4 zalan 2020-01-16 15:56:16 PST 
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 387958 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=387958&action=review
> 
> > Source/WebCore/layout/inlineformatting/LineLayoutContext.cpp:209
> > +inline void LineCandidateContent::reset()
> 
> Does the inlining actually make a difference?
yes, this is a very hot codepath (I wouldn't have made this change otherwise)
Comment 5 zalan 2020-01-16 19:04:05 PST 
Created attachment 388002 [details]
Patch
Comment 6 WebKit Commit Bot 2020-01-16 20:52:10 PST 
Comment on attachment 388002 [details]
Patch

Clearing flags on attachment: 388002

Committed r254736: <https://trac.webkit.org/changeset/254736>
Comment 7 WebKit Commit Bot 2020-01-16 20:52:11 PST 
All reviewed patches have been landed.  Closing bug.