Bug 206362

Summary: REGRESSION: [ Mac Debug WK1 ] inspector/page/overrideSetting-ICECandidateFilteringEnabled.html is a flaky failure
Product: WebKit Reporter: Truitt Savell <tsavell>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bot-watchers-bugzilla, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Truitt Savell 2020-01-16 10:47:30 PST 
inspector/page/overrideSetting-ICECandidateFilteringEnabled.html

Description:
This test is a flaky failure on Mac Debug WK1 very consistently.

History:
https://results.webkit.org/?suite=layout-tests&test=inspector%2Fpage%2FoverrideSetting-ICECandidateFilteringEnabled.html

Diff:

--- /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/inspector/page/overrideSetting-ICECandidateFilteringEnabled-expected.txt
+++ /Volumes/Data/slave/mojave-debug-tests-wk1/build/layout-test-results/inspector/page/overrideSetting-ICECandidateFilteringEnabled-actual.txt
@@ -7,5 +7,5 @@
 Creating data channel...
 PASS: created offer
 PASS: received ICE candidate.
-PASS: Should be able to establish a connection when filtering ice candidates.
+!! TIMEOUT: took longer than 10000ms
Comment 1 Radar WebKit Bug Importer 2020-01-16 10:47:46 PST 
<rdar://problem/58649476>
Comment 2 Truitt Savell 2020-01-16 10:49:54 PST 
This started around r252482
Comment 3 Truitt Savell 2020-01-16 11:16:38 PST 
marked test as failing while the sis investigated: https://trac.webkit.org/changeset/254697/webkit
Comment 4 Devin Rousso 2020-01-17 16:32:39 PST 
I am unable to reproduce this locally using 1000 iterations on debug WK1.
Comment 5 Alexey Proskuryakov 2020-01-18 23:09:07 PST 
This test usually takes several seconds on debug WK1. Other times, it either fails like this or times out completely. Clearly a regression indeed.
Comment 6 Devin Rousso 2020-01-23 10:50:49 PST 
Created attachment 388564 [details]
Patch
Comment 7 BJ Burg 2020-01-23 16:09:32 PST 
Comment on attachment 388564 [details]
Patch

Does not apply
Comment 8 Devin Rousso 2020-01-26 23:16:14 PST 
Created attachment 388832 [details]
Patch
Comment 9 BJ Burg 2020-01-27 10:10:25 PST 
Comment on attachment 388832 [details]
Patch

rs=me
Comment 10 WebKit Commit Bot 2020-01-27 10:54:18 PST 
Comment on attachment 388832 [details]
Patch

Clearing flags on attachment: 388832

Committed r255154: <https://trac.webkit.org/changeset/255154>
Comment 11 WebKit Commit Bot 2020-01-27 10:54:19 PST 
All reviewed patches have been landed.  Closing bug.