| Summary: | Try to simplify the template deduction used by callOperation in DFGSpeculativeJIT | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Robin Morisset <rmorisset> | ||||
| Component: | JavaScriptCore | Assignee: | Robin Morisset <rmorisset> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Robin Morisset
2020-01-15 17:42:40 PST
Created attachment 387879 [details]
Patch
Comment on attachment 387879 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387879&action=review r=me with question. > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:-954 > - callOperation(OperationType operation, NoResultTag, Args... args) Does anyone use NoResultTag now? If not, we should just get rid of it. (In reply to Keith Miller from comment #2) > Comment on attachment 387879 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387879&action=review > > r=me with question. > > > Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h:-954 > > - callOperation(OperationType operation, NoResultTag, Args... args) > > Does anyone use NoResultTag now? If not, we should just get rid of it. It is still used by various other functions. It is not clear whether it can also be removed from those. Comment on attachment 387879 [details] Patch Clearing flags on attachment: 387879 Committed r254717: <https://trac.webkit.org/changeset/254717> All reviewed patches have been landed. Closing bug. Did it make compile times faster? (In reply to Saam Barati from comment #7) > Did it make compile times faster? I was hoping that it would, but it apparently did not (or at least not significantly): https://perf.safari.apple.com/v3/#/charts?since=1578678298555&paneList=((1117-4968-null-null-(5-2.5-500))-(1117-4990-null-null-(5-2.5-500))) |