| Summary: | Add finite timeout when synchronously terminating a service worker | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alex Christensen <achristensen> | ||||||||
| Component: | New Bugs | Assignee: | Alex Christensen <achristensen> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, webkit-bug-importer, youennf | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 207354 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Alex Christensen
2020-01-15 16:37:00 PST
Created attachment 387869 [details]
Patch
Created attachment 387875 [details]
Patch
Comment on attachment 387875 [details] Patch LGTM. In the future, we should be able to remove this syncTerminateWorker and use a timer to kick in process termination if it does not answer soon enough. View in context: https://bugs.webkit.org/attachment.cgi?id=387875&action=review > Source/WebKit/ChangeLog:11 > + and tell the UI process to terminate the hanging service worker process. Continue handling messages during s/. C/. C/ > Source/WebKit/UIProcess/WebProcessPool.cpp:1771 > +void WebProcessPool::terminateServiceWorkers(const WebCore::RegistrableDomain& domain, const PAL::SessionID& sessionID) s/terminateServiceWorkers/terminateServiceWorkerProcess? > Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:429 > + for (auto processPool : WebProcessPool::allProcessPools()) auto* > Source/WebKit/UIProcess/Network/NetworkProcessProxy.h:39 > +#include <WebCore/ServiceWorkerIdentifier.h> Does not seem necessary Created attachment 387946 [details]
Patch
Comment on attachment 387946 [details] Patch Clearing flags on attachment: 387946 Committed r254706: <https://trac.webkit.org/changeset/254706> All reviewed patches have been landed. Closing bug. |