Bug 206318

Summary: Update ANGLE
Product: WebKit Reporter: James Darpinian <jdarpinian>
Component: ANGLEAssignee: James Darpinian <jdarpinian>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, dino, eric.carlson, ews-watchlist, glenn, graouts, gyuyoung.kim, jer.noble, kbr, kondapallykalyan, mcatanzaro, philipj, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=205483
https://bugs.webkit.org/show_bug.cgi?id=198948
Bug Depends on: 207080    
Bug Blocks: 198948, 205483, 206625    
Attachments:
Description Flags
Update ANGLE
none
rebase
dino: review+
Update ANGLE again dino: review+

James Darpinian
Reported 2020-01-15 15:14:29 PST
Update ANGLE
Attachments
Update ANGLE (7.04 MB, patch)
2020-01-15 15:36 PST, James Darpinian 		no flags
DetailsFormatted DiffDiff
rebase (7.04 MB, patch)
2020-01-15 16:34 PST, James Darpinian 		dino: review+
DetailsFormatted DiffDiff
Update ANGLE again (7.98 MB, patch)
2020-02-04 14:12 PST, James Darpinian 		dino: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
James Darpinian
Comment 1 2020-01-15 15:36:12 PST
Created attachment 387857 [details] Update ANGLE
James Darpinian
Comment 2 2020-01-15 16:34:12 PST
Created attachment 387866 [details] rebase
EWS Watchlist
Comment 3 2020-01-15 16:37:58 PST
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Dean Jackson
Comment 4 2020-01-22 15:07:04 PST
I will land in a moment.
Dean Jackson
Comment 5 2020-01-23 10:26:20 PST
Committed r254981: <https://trac.webkit.org/changeset/254981>
Radar WebKit Bug Importer
Comment 6 2020-01-23 10:27:19 PST
<rdar://problem/58839342>
Dean Jackson
Comment 7 2020-01-29 16:45:45 PST
Committed r255403: <https://trac.webkit.org/changeset/255403>
James Darpinian
Comment 8 2020-01-31 16:31:35 PST
Reverted again in r255410 due to continuing test failures. I have found the root cause in bug 207080.
James Darpinian
Comment 9 2020-02-04 14:12:21 PST
Created attachment 389707 [details] Update ANGLE again
Dean Jackson
Comment 10 2020-02-04 16:41:17 PST
Comment on attachment 389707 [details] Update ANGLE again rs=me I will land now.
Dean Jackson
Comment 11 2020-02-04 18:03:08 PST
Committed r255782: <https://trac.webkit.org/changeset/255782>
Michael Catanzaro
Comment 12 2020-02-10 10:26:26 PST
(In reply to Build Bot from comment #3) > Note that there are important steps to take when updating ANGLE. See > http://trac.webkit.org/wiki/UpdatingANGLE Looks like some steps from this wiki page are obsolete? Steps 3 through 6? OK for me to remove those from the wiki page? I'll also add a step mentioning the need to maintain changes.diff.
James Darpinian
Comment 13 2020-02-10 14:55:56 PST
Yes, please do update the wiki, I don't have permission. All of the steps there are obsolete. The steps now are: 1. Run the script Source/ThirdParty/update-angle.sh and follow its instructions. That's it. The script does a git rebase which automatically carries forward all existing modifications such as the license disclaimer mentioned in the old steps. It handles updating the plist file and the changes.diff file and even the CMake files, and it gives instructions for how to modify the XCode build. There are no other manual steps anymore.
James Darpinian
Comment 14 2020-02-10 14:57:05 PST
Sorry, the actual path to the script is Source/ThirdParty/ANGLE/update-angle.sh
Michael Catanzaro
Comment 15 2020-02-11 08:41:13 PST
OK thanks, new wiki page: https://trac.webkit.org/wiki/UpdatingANGLE
Note You need to log in before you can comment on or make changes to this bug.