| Summary: | REGRESSION (r253394): After swiping back during a navigation, WKWebView gets stuck with the forward content, stops repainting | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | cdumez, commit-queue, simon.fraser, thorton | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tim Horton
2020-01-14 17:03:37 PST
Created attachment 387736 [details]
Patch
Comment on attachment 387736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=387736&action=review > Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:262 > m_didCallWillEndSwipeGesture = false; > + m_didCallEndSwipeGesture = false; > + m_removeSnapshotImmediatelyWhenGestureEnds = false; Starting to feel like a state machine. (In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 387736 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=387736&action=review > > > Source/WebKit/UIProcess/ios/ViewGestureControllerIOS.mm:262 > > m_didCallWillEndSwipeGesture = false; > > + m_didCallEndSwipeGesture = false; > > + m_removeSnapshotImmediatelyWhenGestureEnds = false; > > Starting to feel like a state machine. STARTING!? Comment on attachment 387736 [details] Patch Clearing flags on attachment: 387736 Committed r254552: <https://trac.webkit.org/changeset/254552> All reviewed patches have been landed. Closing bug. |