Bug 206261

Summary: Keep RefPtr instead of raw pointer to message queue on WebCoreResourceHandleAsOperationQueueDelegate
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, cdumez, commit-queue, ddkilzer, ews-watchlist, galpeter, ggaren, Hironori.Fujii, rniwa, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Alex Christensen 2020-01-14 14:37:04 PST 
Keep WeakPtrs instead of raw pointers on WebCoreResourceHandleAsOperationQueueDelegate
Comment 1 Alex Christensen 2020-01-14 15:08:07 PST 
Created attachment 387708 [details]
Patch
Comment 2 Alex Christensen 2020-01-14 15:09:47 PST 
Created attachment 387710 [details]
Patch
Comment 3 Alex Christensen 2020-01-14 15:13:55 PST 
Created attachment 387711 [details]
Patch
Comment 4 Alex Christensen 2020-01-14 15:38:19 PST 
Created attachment 387714 [details]
Patch
Comment 5 Alex Christensen 2020-01-14 15:54:30 PST 
Created attachment 387717 [details]
Patch
Comment 6 Alex Christensen 2020-01-14 19:43:17 PST 
Created attachment 387748 [details]
Patch
Comment 7 Alex Christensen 2020-01-14 20:46:52 PST 
Created attachment 387749 [details]
Patch
Comment 8 Ryosuke Niwa 2020-01-14 21:48:21 PST 
<rdar://problem/57562592>
Comment 9 David Kilzer (:ddkilzer) 2020-01-15 10:43:23 PST 
Comment on attachment 387749 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=387749&action=review

r=me if code in CurlRequest.h is okay.

> Source/WebCore/platform/network/curl/CurlRequest.h:67
> +    static Ref<CurlRequest> create(const ResourceRequest& request, CurlRequestClient& client, ShouldSuspend shouldSuspend = ShouldSuspend::No, EnableMultipart enableMultipart = EnableMultipart::No, CaptureNetworkLoadMetrics captureMetrics = CaptureNetworkLoadMetrics::Basic, RefPtr<SynchronousLoaderMessageQueue>&& messageQueue = nullptr)

Is assigning `nullptr` to the default value of a RefPtr<...>&& type allowed?
Comment 10 Alex Christensen 2020-01-15 12:45:37 PST 
Created attachment 387824 [details]
Patch
Comment 11 Alex Christensen 2020-01-15 16:04:05 PST 
Created attachment 387862 [details]
Patch
Comment 12 Alex Christensen 2020-01-15 16:07:57 PST 
(In reply to David Kilzer (:ddkilzer) from comment #9)
> Is assigning `nullptr` to the default value of a RefPtr<...>&& type allowed?
It is!
Comment 13 WebKit Commit Bot 2020-01-15 18:00:21 PST 
Comment on attachment 387862 [details]
Patch

Clearing flags on attachment: 387862

Committed r254659: <https://trac.webkit.org/changeset/254659>
Comment 14 WebKit Commit Bot 2020-01-15 18:00:23 PST 
All reviewed patches have been landed.  Closing bug.
Comment 15 Fujii Hironori 2020-01-16 04:45:49 PST 
Committed r254673: <https://trac.webkit.org/changeset/254673>