| Summary: | [Texmap] Remove unused private variable | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Víctor M. Jáquez L. <vjaquez> | ||||||
| Component: | WebKit Misc. | Assignee: | Víctor M. Jáquez L. <vjaquez> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | calvaris, cmarcelo, commit-queue, ddkilzer, ews-feeder, ews-watchlist, kondapallykalyan, luiz, noam, pnormand, webkit-bug-importer, zan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Víctor M. Jáquez L.
2020-01-14 07:25:37 PST
Created attachment 387653 [details]
Patch
Comment on attachment 387653 [details]
Patch
r=me
The commit-queue encountered the following flaky tests while processing attachment 387653 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch. The commit-queue encountered the following flaky tests while processing attachment 387653 [details]:
The commit-queue is continuing to process your patch.
Comment on attachment 387653 [details] Patch Rejecting attachment 387653 [details] from commit-queue. New failing tests: editing/spelling/spellcheck-attribute.html Full output: https://webkit-queues.webkit.org/results/13305032 Created attachment 387851 [details]
Archive of layout-test-results from webkit-cq-01 for mac-mojave
The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01 Port: mac-mojave Platform: Mac OS X 10.14.6
I don't think those flaky tests turned flaky because of this patch. Comment on attachment 387653 [details] Patch Rejecting attachment 387653 [details] from commit-queue. vjaquez@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. Committed r254685: <https://trac.webkit.org/changeset/254685> |