Bug 206184

Summary: Web Inspector: "Enable Local Override" and "Delete Local Override" are displayed twice in the contextual menu
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Description Devin Rousso 2020-01-13 11:04:52 PST 
.
Comment 1 Devin Rousso 2020-01-13 11:05:02 PST 
<rdar://problem/58409880>
Comment 2 Devin Rousso 2020-01-13 11:06:33 PST 
Created attachment 387547 [details]
Patch
Comment 3 BJ Burg 2020-01-13 11:45:01 PST 
Comment on attachment 387547 [details]
Patch

r=me

Kind of weird, but I guess it's fine. I guess the other option is to type-check the represented object and not add them in the case they are overrides already.
Comment 4 WebKit Commit Bot 2020-01-13 19:44:02 PST 
The commit-queue encountered the following flaky tests while processing attachment 387547 [details]:

editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org)
fast/hidpi/image-srcset-relative-svg-canvas-2x.html bug 206211 (author: yoav@yoav.ws)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2020-01-13 19:44:34 PST 
Comment on attachment 387547 [details]
Patch

Clearing flags on attachment: 387547

Committed r254485: <https://trac.webkit.org/changeset/254485>
Comment 6 WebKit Commit Bot 2020-01-13 19:44:36 PST 
All reviewed patches have been landed.  Closing bug.