Bug 206180

Summary:

[EWS] Status bubble tooltip might display success message sometimes on a failed build

Product:

WebKit

Reporter:

Aakash Jain <aakash_jain>

Component:

Tools / Tests

Assignee:

Aakash Jain <aakash_jain>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aakash_jain, ap, jbedard, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	jbedard: review+

Description Aakash Jain 2020-01-13 10:06:42 PST

[EWS] Status bubble tooltip might display success message sometimes on a failed build if the last step in the build succeeds. For the failed builds, status bubble tooltip displays the message from the last step. If the last step is successful (but some other step failed), it might be misleading.

e.g.: https://ews-build.webkit.org/#/builders/20/builds/11444

Comment 1 Aakash Jain 2020-01-14 15:39:57 PST

Created attachment 387715 [details]
Patch

Comment 2 Aakash Jain 2020-01-14 15:44:18 PST

Tested in https://ews.webkit-uat.org/status-bubble/387402/

Comment 3 Aakash Jain 2020-01-14 17:08:36 PST

Committed r254545: <https://trac.webkit.org/changeset/254545>

Comment 4 Radar WebKit Bug Importer 2020-01-14 17:09:35 PST

<rdar://problem/58588995>